From d52d704e978089dc0b3d90748983c7529cecc3ad Mon Sep 17 00:00:00 2001 From: lilserf Date: Mon, 4 Jan 2021 15:33:51 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Steffen --- src/App.vue | 4 +++- src/components/Menu.vue | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/App.vue b/src/App.vue index a053447..63c5772 100644 --- a/src/App.vue +++ b/src/App.vue @@ -103,7 +103,9 @@ export default { this.$store.commit("toggleModal", "roles"); break; case "v": - this.$store.commit("toggleModal", "voteHistory"); + if (this.session.voteHistory.length) { + this.$store.commit("toggleModal", "voteHistory"); + } break; case "escape": this.$store.commit("toggleModal"); diff --git a/src/components/Menu.vue b/src/components/Menu.vue index c6519f4..dcb53cc 100644 --- a/src/components/Menu.vue +++ b/src/components/Menu.vue @@ -114,7 +114,7 @@ v-if="session.voteHistory.length" @click="toggleModal('voteHistory')" > - Nomination history[V] + Nomination history[V]
  • Leave Session