From d88b02d19908cee8499367afc421a7272391dd14 Mon Sep 17 00:00:00 2001 From: lilserf Date: Mon, 4 Jan 2021 10:50:15 -0500 Subject: [PATCH 1/3] Add V hotkey for the vote history modal --- src/App.vue | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/App.vue b/src/App.vue index 0b6fac6..a053447 100644 --- a/src/App.vue +++ b/src/App.vue @@ -102,6 +102,9 @@ export default { if (this.session.isSpectator) return; this.$store.commit("toggleModal", "roles"); break; + case "v": + this.$store.commit("toggleModal", "voteHistory"); + break; case "escape": this.$store.commit("toggleModal"); } From 0b78848d03a9d2d50fb2fdaeba795ecaf367cccb Mon Sep 17 00:00:00 2001 From: lilserf Date: Mon, 4 Jan 2021 10:51:52 -0500 Subject: [PATCH 2/3] Add V hotkey for vote history --- src/components/Menu.vue | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/Menu.vue b/src/components/Menu.vue index 6eb4d34..c6519f4 100644 --- a/src/components/Menu.vue +++ b/src/components/Menu.vue @@ -114,8 +114,7 @@ v-if="session.voteHistory.length" @click="toggleModal('voteHistory')" > - Nomination history - + Nomination history[V]
  • Leave Session From d52d704e978089dc0b3d90748983c7529cecc3ad Mon Sep 17 00:00:00 2001 From: lilserf Date: Mon, 4 Jan 2021 15:33:51 -0500 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Steffen --- src/App.vue | 4 +++- src/components/Menu.vue | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/App.vue b/src/App.vue index a053447..63c5772 100644 --- a/src/App.vue +++ b/src/App.vue @@ -103,7 +103,9 @@ export default { this.$store.commit("toggleModal", "roles"); break; case "v": - this.$store.commit("toggleModal", "voteHistory"); + if (this.session.voteHistory.length) { + this.$store.commit("toggleModal", "voteHistory"); + } break; case "escape": this.$store.commit("toggleModal"); diff --git a/src/components/Menu.vue b/src/components/Menu.vue index c6519f4..dcb53cc 100644 --- a/src/components/Menu.vue +++ b/src/components/Menu.vue @@ -114,7 +114,7 @@ v-if="session.voteHistory.length" @click="toggleModal('voteHistory')" > - Nomination history[V] + Nomination history[V]
  • Leave Session